Skip to content

[String] Fix missing locale in slugger substitution map #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

[String] Fix missing locale in slugger substitution map #14003

merged 1 commit into from
Aug 3, 2020

Conversation

moltam
Copy link
Contributor

@moltam moltam commented Jul 28, 2020

The locale was missing from the substitution map, so the example code did not replace the symbols as the comment stated.

@xabbuh xabbuh added this to the 5.1 milestone Aug 3, 2020
@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2020

Good catch, thanks @moltam.

@xabbuh xabbuh merged commit 50dc02e into symfony:5.1 Aug 3, 2020
@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2020

And congratulations to your first Symfony documentation contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@moltam @xabbuh @carsonbot