Skip to content

Change unit test definition #13983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Change unit test definition #13983

merged 1 commit into from
Sep 12, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Jul 20, 2020

I'm not sure about the unit test definition. Considering unit tests as testing against a single class often leads to over-mocking. What about talking of single behaviour instead ?

@javiereguiluz javiereguiluz changed the base branch from 3.4 to 4.4 September 12, 2020 14:21
@javiereguiluz javiereguiluz merged commit fa19b45 into symfony:4.4 Sep 12, 2020
@javiereguiluz
Copy link
Member

Thanks for this proposal Laurent. While merging we did more changes following the definition of "unit testing" found in the Wikipedia: https://en.wikipedia.org/wiki/Unit_testing

@l-vo l-vo deleted the patch-6 branch September 12, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants