Fixed the Quick Tour sample code to work just by copy and paste. #13981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
fix/quick_tour_php
branch
from
bcddb29 to
8f3ff01
Compare
|
Hideki, thanks a lot for this contribution and congrats on your first Symfony Docs contribution 🎉 In the past we discussed about doing or not doing this ... but you are right: these docs are for beginners, so we should make it easier for them. Cheers! どうもありがとう |
|
Thank you for your kind support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginners try to imitate the code of the quick tour as it is, but it does not work as it is because there is no
<?php. Those pages are for beginners, so it's better to work just by copy and paste.