Skip to content

Update best_practices.rst #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Update best_practices.rst #13950

merged 1 commit into from
Sep 25, 2020

Conversation

elghailani
Copy link
Contributor

Improving Validation Constraints & Internationalization

@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 September 25, 2020 15:46
@javiereguiluz javiereguiluz merged commit 72e99f7 into symfony:4.4 Sep 25, 2020
@javiereguiluz
Copy link
Member

Thanks for these improvement too! We reverted this change -> reused -> checked because we thing "reused" is more precise in this case.

@elghailani elghailani deleted the patch-5 branch September 25, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elghailani @javiereguiluz @carsonbot