[Contributing] Improved CS #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (true === $dummy) { | ||
| return; | ||
| } | ||
| if ('string' === $dummy) { | ||
| $dummy = substr($dummy, 0, 5); | ||
| } | ||
| if (mergedOptions['some_default'] === 'values') { |
There was a problem hiding this comment.
This should be 'values' === $mergedOptions['some_default'].
There was a problem hiding this comment.
Yes, you're right. That's the part I personally don't like about the Symfony CS, but I will change it soon.
There was a problem hiding this comment.
Is it an option to at this rule to the Coding Standards @fabpot ? I can't find this rule.
|
Hey guys! I've merged this PR - it's a big improvement and I think we've addressed any issues. If any remain, just open up another PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some code improvements to the coding standards:
if ... elsestatements, because it is not clear if theelseneeds to be on a new line or not