Skip to content

Update error_pages.rst #13877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Update error_pages.rst #13877

merged 1 commit into from
Jun 22, 2020

Conversation

atailouloute
Copy link
Contributor

setException is replaced by setThrowable in SF5+

@javiereguiluz javiereguiluz added this to the 5.0 milestone Jun 22, 2020
@javiereguiluz
Copy link
Member

You are on a roll! thanks Ahmed

@javiereguiluz javiereguiluz merged commit 900f3e4 into symfony:5.0 Jun 22, 2020
@Florian-Merle Florian-Merle mentioned this pull request Nov 21, 2024
Merged
OskarStark added a commit that referenced this pull request Nov 22, 2024
@OskarStark
bug #20404 Fix error_pages.rst setResponse() (Florian-Merle)
29c83bd 
This PR was merged into the 5.4 branch.

Discussion
----------

Fix error_pages.rst setResponse()

I believe #13877 should not have been merged because `setException` has been replaced by `setThrowable`, not `setResponse`.

Commits
-------

8905736 Fix error_pages.rst setResponse()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atailouloute @javiereguiluz @carsonbot