Skip to content

updated generated code according to make:auth results in Symfony 5.1 #13864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

updated generated code according to make:auth results in Symfony 5.1 #13864

merged 1 commit into from
Jun 23, 2020

Conversation

nabbisen
Copy link
Contributor

No description provided.

@javiereguiluz
Copy link
Member

@nabbisen thanks for this contribution!

I see this was introduced in MakerBundle in May 2019 (symfony/maker-bundle@47ee44b#diff-a8079906bb7a0cfe45b4b5733b0944d9). Is there any reason for adding these docs to Symfony 5.1 only? Could we merge this in 4.4 too?

@nabbisen
Copy link
Contributor Author

@javiereguiluz
Thank you for your reviewing.

Is there any reason for adding these docs to Symfony 5.1 only?

No.

Could we merge this in 4.4 too?

Yes, please.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jun 23, 2020
@javiereguiluz javiereguiluz changed the base branch from 5.1 to 4.4 June 23, 2020 07:18
@javiereguiluz
Copy link
Member

Merged in 4.4! (and all the other upper branches) Thanks!

@javiereguiluz javiereguiluz merged commit 2135c9e into symfony:4.4 Jun 23, 2020
@maxhelias maxhelias mentioned this pull request Aug 10, 2020
Merged
xabbuh added a commit that referenced this pull request Aug 21, 2020
@xabbuh
minor #14047 [Security] Fix logout on form login setup (maxhelias)
72e1f87 
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Fix logout on form login setup

Introduced with #13864

Commits
-------

22fd47e Fix logout on form login setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nabbisen @javiereguiluz @carsonbot