Skip to content

Replaced orphan " and" at the end of the sentence by a dot #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

Levure
Copy link
Contributor

@Levure Levure commented Jun 16, 2020

No description provided.

@borisklotz
Copy link

I would suggest to use a colon instead of a period sign, as most paragraphs followed by a code sample end with a colon not a period.

@javiereguiluz
Copy link
Member

@Levure thanks! @borisklotz is right. The double :: at the end of some text and before a code sample is needed. In RST, adding :: before a code sample tells the doc parser to highlight the code as PHP. (We could use .. code-block:: php ... but we have so many PHP examples, that we use the :: trick instead. Please note, we're not planning to change this, so no pull request to introduce .. code-block:: php 😅 Thanks!).

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jun 17, 2020
@javiereguiluz javiereguiluz merged commit f0de487 into symfony:4.4 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants