Skip to content

Update : advertize ⮞ advertise #13805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Update : advertize ⮞ advertise #13805

merged 1 commit into from
Jun 11, 2020

Conversation

Levure
Copy link
Contributor

@Levure Levure commented Jun 10, 2020

I thought it was a typo, but after some checks it seems that the Z form (advertize) is old british english and quite less used than the S form (advertise).

So let's talk of "update" instead of "typo fix" 😉

@javiereguiluz
Copy link
Member

In Symfony Docs we use American English (and recommend the American English Oxford dictionary as reference: https://symfony.com/doc/current/contributing/documentation/standards.html#english-language-standards) but this is a special case, because even if "advertize" is the American English word, most people use "advertise" (and even dictionaries and Google mark "advertize" in red as a wrong word). So, let's do this change. Thanks.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jun 11, 2020
@javiereguiluz javiereguiluz merged commit be85066 into symfony:3.4 Jun 11, 2020
@Levure
Copy link
Contributor Author

Levure commented Jun 11, 2020

Thanks for the American English Oxford dictionnary reference, i've missed it.
I will double check my future PR with it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants