Fix form unit testing code sample #13744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoannrenard thanks for this contribution. However, this is tricky. This object is both "the object to test" and "the form data" at the same time. When you submit the form, the object is modified and contains the data submitted in the form. @xabbuh @OskarStark what do you think? Should we update the example or leave it as is? Thanks! |
xabbuh
reviewed
Jun 3, 2020
yoannrenard
force-pushed
the
fix/form-unit-testing-code-sample
branch
from
f7923b8 to
62aee7c
Compare
xabbuh
approved these changes
Jun 4, 2020
|
Yoann thanks and congrats on your first Symfony Docs contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix of this little bit of code that was misleading.