Skip to content

add smsapi-notifier #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

add smsapi-notifier #13716

merged 1 commit into from
Aug 21, 2020

Conversation

szepczynski
Copy link
Contributor

add smsapi-notifier documentation

@javiereguiluz javiereguiluz added Notifier Waiting Code Merge Docs for features pending to be merged labels May 28, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Aug 18, 2020
This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[Notifier] add support for smsapi-notifier

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#13716

Hi,

I've created integration to notifier to support polish sms operator - smsapi.pl

Here is smsapi-notifier integration: https://github.com/szepczynski/smsapi-notifier. Can you grab this code and make as symfony/smsapi-notifier?

This PR includes changes in notifier and framework-bundle to support smsapi transport as well as other included in notifier component.

Could someone integrate this into notifier component?

Commits
-------

91c2530 [Notifier] add support for smsapi-notifier
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Aug 18, 2020
This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[Notifier] add support for smsapi-notifier

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#13716

Hi,

I've created integration to notifier to support polish sms operator - smsapi.pl

Here is smsapi-notifier integration: https://github.com/szepczynski/smsapi-notifier. Can you grab this code and make as symfony/smsapi-notifier?

This PR includes changes in notifier and framework-bundle to support smsapi transport as well as other included in notifier component.

Could someone integrate this into notifier component?

Commits
-------

91c25303f7 [Notifier] add support for smsapi-notifier
@OskarStark OskarStark added this to the 5.2 milestone Aug 19, 2020
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Aug 19, 2020
@xabbuh
Copy link
Member

xabbuh commented Aug 21, 2020

Thank you for your first contribution to the Symfony documentation @szepczynski.

@xabbuh xabbuh merged commit 14d6e23 into symfony:master Aug 21, 2020
xabbuh added a commit that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants