Removed ClassLoader, DotEnv, Mercure, WebLink, Templating, ErrorHandler and Polyfill component docs #13706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2020
wouterj
force-pushed
the
components/batch-remove
branch
from
6202214 to
509589e
Compare
wouterj
changed the title
wouterj
force-pushed
the
components/batch-remove
branch
from
509589e to
bafac86
Compare
wouterj
changed the title
wouterj
commented
May 25, 2020
| @@ -243,8 +243,7 @@ the ``templates/layout.php``: | |||
| You now have a setup that will allow you to reuse the layout. | |||
| Unfortunately, to accomplish this, you're forced to use a few ugly | |||
| PHP functions (``ob_start()``, ``ob_get_clean()``) in the template. Symfony | |||
| solves this using a :doc:`Templating </components/templating>` component. | |||
| You'll see it in action shortly. | |||
| solves this using a `Templating`_ component. You'll see it in action shortly. | |||
There was a problem hiding this comment.
I know this sentence is no longer true. However, I consider updating it out-of-scope. This whole article is also in need for an update (it's written for Symfony 2 - lot's has changed since then).
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 26, 2020
…ME with minimal example (wouterj) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#13706 We're about to delete some more component docs. The minimal examples where copy/pasted from the original component docs. Commits ------- f3b8a58 [DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example
wouterj
force-pushed
the
components/batch-remove
branch
from
20dcb52 to
522d63b
Compare
xabbuh
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's take a bigger step and remove some more docs. These components were some more easy picks.
The polyfills are already listed in https://symfony.com/components and their README files describe the polyfills contained in each package already. So I think we can remove them without any other change.