Skip to content

Resolve the DATABASE_URL env var in config examples #13689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020

Conversation

javiereguiluz
Copy link
Member

This was asked on Symfony's Slack.

The official Symfony recipe uses too by default: https://github.com/symfony/recipes/blob/c7d81ffbff3e2335532b21c0f71289a5489151c8/doctrine/doctrine-bundle/2.0/config/packages/doctrine.yaml#L3

@nicolas-grekas would you agree with this change? Thanks!

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I agree!

@javiereguiluz javiereguiluz merged commit 0313092 into symfony:4.4 May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants