Skip to content

[String] Deprecated the Inflector docs #13670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

[String] Deprecated the Inflector docs #13670

merged 1 commit into from
May 16, 2020

Conversation

javiereguiluz
Copy link
Member

Fixes #13638.

@javiereguiluz javiereguiluz added Inflector DEPRECATED. Use "String" label. String labels May 15, 2020
@javiereguiluz javiereguiluz added this to the 5.1 milestone May 15, 2020
wouterj
wouterj approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It does need a versionadded directive though in components/string afaics

@javiereguiluz javiereguiluz merged commit bd1b079 into symfony:master May 16, 2020
@wouterj
Copy link
Member

wouterj commented May 16, 2020

Fyi, there is a very minor syntax typo in the versionadded directive. I've fixed it directly on master in 30febcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Inflector DEPRECATED. Use "String" label. Status: Reviewed String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Inflector][String] Move Inflector in String
3 participants
@javiereguiluz @wouterj @carsonbot