Skip to content

[Console] Remove invalid argument #13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020
Merged

[Console] Remove invalid argument #13645

merged 1 commit into from
May 11, 2020

Conversation

apfelbox
Copy link
Contributor

@apfelbox apfelbox commented May 5, 2020

Passing in the command is only valid when passing the arguments to the application (https://symfony.com/doc/current/console/command_in_controller.html), not if we directly call the command.

This would currently result in an InvalidArgumentException: The "command" argument does not exist.

@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 May 11, 2020 13:39
@javiereguiluz
Copy link
Member

Thank you Jannik.

@javiereguiluz javiereguiluz merged commit 386ec7b into symfony:4.4 May 11, 2020
@apfelbox apfelbox deleted the patch-1 branch May 12, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants