Command fix in upgrade_major.rst #13547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiseptikk
changed the title
|
@antiseptikk thanks a lot for this contribution. Sadly, when I tried to merge it with our proprietary tool, it failed (and the tool closed the pull request automatically). I also tried to merge #13556 but it failed in the same way. It turns out that the article had already been updated (you can see "symfony/*" wrapped in quotes in https://symfony.com/doc/current/setup/upgrade_major.html). I'm sorry and thanks again. |
|
FYI, the fix was merged with #13610. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, without the double quotes i've got
no matches found: symfony/*error.