[Security] More radically remove Testing/HTTP Authentication contents #13523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2020
javiereguiluz
approved these changes
Apr 14, 2020
wouterj
added a commit
that referenced
this pull request
Apr 16, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Fix test login example for 4.4 - 5.0 applications Fixes part of #13376 Since Symfony 4.4, user equality is checked on each request thus the current method (with a non-existent user) is broken. I've updated the example to use something similar to the new `loginUser()` method in Symfony 5.1. This fixes the docs for 4.4 and 5.0. See #13523 for improvements of this chapter in 5.1. Commits ------- fb8123a Fix test login example for 4.4 - 5.0 applications
wouterj
force-pushed
the
issue-13376/security-functional-test
branch
from
3482392 to
28bb445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #13376
We couldn't remove this article because it's a very important article in the docs. However, the contents no longer make sense in 5.1. I think it's better to remove the contents completely and link to older versions of this article instead.