RepeatedType overrides mapped value for the type to work properly
#13519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biozshock
force-pushed
the
repeated-type_not-mapped-inner
branch
from
e7d9a61 to
6bc157f
Compare
HeahDude
reviewed
Apr 10, 2020
reference/forms/types/repeated.rst
Outdated
| @@ -129,6 +129,11 @@ the label:: | |||
| 'second_options' => ['label' => 'Repeat Password'], | |||
| ]); | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
What about line 100 instead?
There was a problem hiding this comment.
For me this is most logic place to have a note about options. I would like to have a note about this exactly at the place where documentation describes options for inner fields.
There was a problem hiding this comment.
I think this information is too important and should be shown before any options. This is needed in order to handle validation, and the line I linked is about that section.
There was a problem hiding this comment.
Thanks, I leave that one open for now.
biozshock
force-pushed
the
repeated-type_not-mapped-inner
branch
from
6bc157f to
94980d2
Compare
biozshock
force-pushed
the
repeated-type_not-mapped-inner
branch
from
94980d2 to
b29335a
Compare
|
Side note: we should wait next patch of 3.4 before merging here. |
HeahDude
added
Waiting Code Merge
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Apr 13, 2020
…(biozshock) This PR was merged into the 3.4 branch. Discussion ---------- [Form] RepeatedType should always have inner types mapped | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Doc PR| symfony/symfony-docs#13519 | | Tickets | Fix #36410 | License | MIT Always set mapped=true to override inner type mapped setting. Throw an exception if inner types of RepeatedType has mapped=false Commits ------- 728cd66 RepeatedType should always have inner types mapped
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Apr 13, 2020
…(biozshock) This PR was merged into the 3.4 branch. Discussion ---------- [Form] RepeatedType should always have inner types mapped | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Doc PR| symfony/symfony-docs#13519 | | Tickets | Fix #36410 | License | MIT Always set mapped=true to override inner type mapped setting. Throw an exception if inner types of RepeatedType has mapped=false Commits ------- 728cd66a13 RepeatedType should always have inner types mapped
javiereguiluz
added
Status: Reviewed
and removed
Waiting Code Merge
|
Thank you Artem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to the documentation about overridden
mappedoption for inner fields.