Skip to content

[Validator] Fixed Traverse constraint reference #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

[Validator] Fixed Traverse constraint reference #13491

merged 1 commit into from
Apr 12, 2020

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Apr 5, 2020

I'm sorry I've messed up things in #11310. Now I see that I missed #12967, this fixes it.

@HeahDude HeahDude added this to the 3.4 milestone Apr 5, 2020
@HeahDude HeahDude requested a review from xabbuh as a code owner April 5, 2020 00:57
@HeahDude HeahDude linked an issue Apr 5, 2020 that may be closed by this pull request
Fix the documentation of the Traverse constraint #12967
Closed
@HeahDude HeahDude mentioned this pull request Apr 5, 2020
Closed
@HeahDude HeahDude force-pushed the validator/fix-traverse branch 10 times, most recently from 18dca21 to 3ff0acd Compare April 5, 2020 01:24
guilliamxavier
guilliamxavier reviewed Apr 5, 2020
View reviewed changes
Copy link
Contributor

@guilliamxavier guilliamxavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HeahDude. I can't really say for the use case (hopefully @xabbuh will) but I have left a few editorial comments.

@HeahDude HeahDude force-pushed the validator/fix-traverse branch 2 times, most recently from 3478ab6 to d670d53 Compare April 5, 2020 11:43
@HeahDude
Copy link
Contributor Author

HeahDude commented Apr 5, 2020

Thanks @guilliamxavier for the review, I've addressed your comment and also added more doc about the default and the traverse option.

xabbuh
xabbuh reviewed Apr 5, 2020
View reviewed changes
@HeahDude HeahDude force-pushed the validator/fix-traverse branch from d670d53 to 47dc3c5 Compare April 5, 2020 11:50
guilliamxavier
guilliamxavier reviewed Apr 5, 2020
View reviewed changes
@HeahDude HeahDude force-pushed the validator/fix-traverse branch from 47dc3c5 to 2a4d756 Compare April 5, 2020 12:39
@HeahDude HeahDude force-pushed the validator/fix-traverse branch from 2a4d756 to ef5c989 Compare April 5, 2020 12:40
@HeahDude HeahDude merged commit d9d0f61 into symfony:3.4 Apr 12, 2020
@HeahDude HeahDude deleted the validator/fix-traverse branch April 12, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilliamxavier guilliamxavier guilliamxavier left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
bug Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

Fix the documentation of the Traverse constraint
4 participants
@HeahDude @xabbuh @guilliamxavier @carsonbot