Skip to content

[HttpClient] Document AMPHP HttpClient integration for HTTP/2 #13487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Apr 4, 2020

Fixes #13293

Just below the shown diff, there is this paragraph:

Support for HTTP/2 PUSH works out of the box when libcurl >= 7.61 is used with
PHP >= 7.2.17 / 7.3.4: pushed responses are put into a temporary cache and are
used when a subsequent request is triggered for the corresponding URLs.

Should AMPHP also be added here?

@wouterj wouterj added this to the 5.1 milestone Apr 4, 2020
@wouterj wouterj force-pushed the issue-13293/http2-http-client branch from 3abb7bb to e0a4905 Compare April 4, 2020 15:24
@wouterj wouterj requested a review from nicolas-grekas April 4, 2020 15:26
@javiereguiluz
Copy link
Member

Thanks Wouter.

@javiereguiluz javiereguiluz merged commit 6e9eb32 into symfony:master Apr 6, 2020
@javiereguiluz
Copy link
Member

Note that I didn't update the paragraph you mentioned while merging ... because it was not clear if we should update it or not. We can do that in a different PR. Thanks.

@wouterj wouterj deleted the issue-13293/http2-http-client branch April 6, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpClient] Add portable HTTP/2 implementation based on Amp's HTTP cli…
4 participants