Removed Routing component docs #13431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Mar 30, 2020
javiereguiluz
approved these changes
Mar 30, 2020
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 4, 2020
… (wouterj) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Add installation and minimal example to README | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#13431 Similair to what I did in #35552, this PR updates the README of the Routing component to include a minimal example and installation command. Commits ------- be66120 Add installation and minimal example to README
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Apr 4, 2020
… (wouterj) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Add installation and minimal example to README | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#13431 Similair to what I did in #35552, this PR updates the README of the Routing component to include a minimal example and installation command. Commits ------- be6612060c Add installation and minimal example to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we already did a good job in removing all framework-usage information to the main Routing guide. I've moved the first example to the Routing component README (symfony/symfony#36246).
This means we're loosing some information on file loaders and the all-in-one router, but I don't think that matters much (the component is small enough to follow what's happening while looking at the source code).