Skip to content

Update error_pages.rst #13428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Update error_pages.rst #13428

merged 1 commit into from
Mar 30, 2020

Conversation

abdounikarim
Copy link
Contributor

remove aliases

dbrumann
dbrumann approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this is handled in other places. I personally like using the aliases when working with flex, but I'd rather have the full names in the docs to make it easier for people to look up the component, e.g. on packagist. So, 👍 from me.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Mar 30, 2020
@javiereguiluz javiereguiluz changed the base branch from master to 4.4 March 30, 2020 13:48
@javiereguiluz
Copy link
Member

At first we used aliases ... but then we changed our minds and now we always try to use full package names (note: there are some cases in the docs where we use aliases. They are legit uses, so please, don't submit PRs to change them). Merged! Thanks.

@javiereguiluz javiereguiluz merged commit f8119c1 into symfony:4.4 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@abdounikarim @javiereguiluz @dbrumann @carsonbot