Explaining default logout path #13427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code sample `path: app_logout` is wrong, since you don't have to pass the route's *name*, but rather its `path` (i.e. `/logout`)! Please double-check the XML and PHP config - I merely guessed those. Thanks to symfony#13424 (review)
Merged
|
I do pass the route name on my project (4.4, 5.0) and it works, maybe both are ok? |
|
Yeah, you're probably right - noticed that yesterday too... ;-) So what should we do now? What's the recommended way? Since the option is called |
|
Hi! The recommended way is to configure a route name, as shown throughout the documentation. So I think that means there is nothing to fix here, so I'm going to close this PR. Thanks for understanding. Btw see #10423 (comment) , which was the PR changing some of the last path usages to routes in the docs in the 4.1+ versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code sample
path: app_logoutis wrong, since you don't have to pass the route's name, but rather itspath(i.e./logout)!Please double-check the XML and PHP config - I merely guessed those.
Thanks to #13424 (review)