Skip to content

Make sure one can copy NPM command #13425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 26, 2020

@javiereguiluz
Copy link
Member

Thanks for this Tobias. I understand the issue ... but I wonder if showing two fully-working examples would make some people think that they need to run both commands.

Maybe we should allow to copy commented contents in commands (except the prompt contents)?

@Nyholm
Copy link
Member Author

Nyholm commented Mar 27, 2020

but I wonder if showing two fully-working examples would make some people think that they need to run both commands.

I doubt that is the case.

I like that I cannot copy comment, but could one only excluded comments like

# Cannot copy me
# $ echo "can copy me since I start with '# $'"

@dbrumann
Copy link
Contributor

I think it's already clear from the surrounding text that this an alternative to yarn.

If I remember correctly yarn/npm will issue a warning to the user if they encounter each others lock file. I think both the text in the docs and that warning should be enough hints to prevent issues.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Mar 27, 2020
Comments cannot be copies
@javiereguiluz javiereguiluz changed the base branch from master to 3.4 March 27, 2020 14:23
@javiereguiluz javiereguiluz merged commit 3e6ea42 into symfony:3.4 Mar 27, 2020
@javiereguiluz
Copy link
Member

You made me change my mind. I've merged this in 3.4 (and all the other branches). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants