Fix typehint of parameter for MicrokernelTrait::configureRoutes() #13394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be RoutingConfigurator instead of RouteCollectionBuilder according to https://github.com/symfony/symfony/blob/master/UPGRADE-5.1.md#frameworkbundle
|
Thank you Joao. |
|
@jpjoao is you found some typo in the Symfony UPGRADE file, please open a pull request in github.com/symfony/symfony to fix it (this file is not generated automatically). Thanks! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Mar 23, 2020
….md file (jpjoao) This PR was merged into the 5.1-dev branch. Discussion ---------- Fix typo on deprecated parameter typehint on UPGRADE-5.1.md file | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | symfony/symfony-docs#13394 Fix typo. Commits ------- 4939d4c [FrameworkBundle] Fix typo on deprecated parameter typehint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now
RoutingConfiguratorinstead ofRouteCollectionBuilderaccording to https://github.com/symfony/symfony/blob/master/UPGRADE-5.1.md#frameworkbundleAlso... There is a typo on the type on the mentioned file. Should I make PR to it or is it generated automatically?