[HttpClient] Expand MockResponse example with HTTP status codes #13387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas could you please check if this contribution is correct? If it is, maybe we should update HttpClient component ... because this doesn't look very "ergonomic" when testing failures. Thanks! |
components/http_client.rst
Outdated
| use Symfony\Component\HttpClient\Response\MockResponse; | ||
|
|
||
| $client = new MockHttpClient([ | ||
| new MockResponse('...', ['response_headers' => ['HTTP/1.1 500 Internal Server Error']]), |
There was a problem hiding this comment.
there is a better way, which is to define the http_code info instead of response_headers
carsonbot
changed the title
Show how to create MockResponses with status codes different than "200 OK"
|
We merged this (in 4.4 branch and up) and we included Nico's simplified solution to mock response errors. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.