Skip to content

use NotNull instead of NotBlank #13386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 21, 2020

Since we have the Type constraint enforcing strings and the Length constraint ensuring that the empty strings are rejected, wouldn't it be more sensible to use the more strict NotNull constraint?

@xabbuh xabbuh added this to the 5.1 milestone Mar 21, 2020
@OskarStark
Copy link
Contributor

But if we enforce a string it’s clear it cannot be null, or?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 21, 2020

@javiereguiluz
Copy link
Member

Thank you Christian.

@javiereguiluz javiereguiluz merged commit a891aa2 into symfony:master Mar 23, 2020
@xabbuh xabbuh deleted the pr-13206 branch March 23, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants