Consider option "allowEmptyString" in examples #13358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Mar 16, 2020
reference/constraints/Length.rst
Outdated
| @@ -42,7 +42,8 @@ and "50", you might add the following: | |||
| * min = 2, | |||
| * max = 50, | |||
| * minMessage = "Your first name must be at least {{ limit }} characters long", | |||
| * maxMessage = "Your first name cannot be longer than {{ limit }} characters" | |||
| * maxMessage = "Your first name cannot be longer than {{ limit }} characters", | |||
| * allowEmptyString = true | |||
There was a problem hiding this comment.
I would set this option to false. Allowing the empty string in this context doesn't seem to make much sense to me.
There was a problem hiding this comment.
Makes sense. I set this option to false
W0rma
force-pushed
the
fix-examples-length-constraint
branch
from
870b989 to
a0ffdb4
Compare
xabbuh
approved these changes
Mar 16, 2020
|
Thank you @W0rma. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://symfony.com/doc/4.4/reference/constraints/Length.html#allowemptystring the option "allowEmptyString" is mandatory if "min" is set (only for symfony 4.4). Therefore I'd like to consider this in the examples.