Skip to content

[Form] Better explicit cloning with "by_reference" option #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

[Form] Better explicit cloning with "by_reference" option #13348

merged 1 commit into from
Mar 16, 2020

Conversation

HeahDude
Copy link
Contributor

Fixes #8182.

@HeahDude HeahDude added the Form label Mar 15, 2020
@HeahDude HeahDude added this to the 3.4 milestone Mar 15, 2020
@HeahDude HeahDude requested a review from xabbuh as a code owner March 15, 2020 17:44
@HeahDude HeahDude linked an issue Mar 15, 2020 that may be closed by this pull request
[Form] by_reference talks about setters?! #8182
Closed
@javiereguiluz
Copy link
Member

Thank you Jules.

@javiereguiluz javiereguiluz merged commit da7b840 into symfony:3.4 Mar 16, 2020
@HeahDude HeahDude deleted the fix/by_reference branch March 16, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[Form] by_reference talks about setters?!
4 participants
@HeahDude @javiereguiluz @yceruto @carsonbot