Skip to content

Add missing normalizers introduced between 3.4 and 4.4 #13327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

Add missing normalizers introduced between 3.4 and 4.4 #13327

merged 1 commit into from
Mar 12, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Mar 10, 2020

No description provided.

@l-vo l-vo force-pushed the add_missing_normalizers_4.4 branch from 20717e5 to b8f0a0e Compare March 10, 2020 10:01
@maxhelias
Copy link
Contributor

To be more precise in 4.1 and 4.4.
And if I'm not mistaken in the process, you can target the 4.4 branch and use the versionadded block with the right version. And after the merge, open a new PR on 5.0 branch to remove this block.

@OskarStark
Copy link
Contributor

And after the merge, open a new PR on 5.0 branch to remove this block.

We would remove the versionadded when upmerging into 5.0 👍

@javiereguiluz javiereguiluz added this to the 4.4 milestone Mar 12, 2020
@javiereguiluz javiereguiluz changed the base branch from master to 4.4 March 12, 2020 12:35
@javiereguiluz javiereguiluz force-pushed the add_missing_normalizers_4.4 branch from b8f0a0e to 08be095 Compare March 12, 2020 12:35
@javiereguiluz javiereguiluz merged commit 9cf19c8 into symfony:4.4 Mar 12, 2020
@javiereguiluz
Copy link
Member

Thanks Laurent! We added the missing versionadded directives while merging this.

@l-vo l-vo deleted the add_missing_normalizers_4.4 branch March 12, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Serializer Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@l-vo @maxhelias @OskarStark @javiereguiluz @carsonbot