Skip to content

[DI] Improve an example about automatic tags and bundles #13305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

[DI] Improve an example about automatic tags and bundles #13305

merged 1 commit into from
Mar 5, 2020

Conversation

javiereguiluz
Copy link
Member

I just needed this inside a bundle ... and the example only shows a Symfony app ... so this was confusing to me.

But if you prefer to not expand this example, it's OK to close this. Thanks!

@javiereguiluz javiereguiluz added this to the 4.4 milestone Mar 4, 2020
HeahDude
HeahDude approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wouterj
wouterj approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with documenting this, as I think this feature will mostly be used by bundle authors.

OskarStark
OskarStark approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ✌🏻

@javiereguiluz javiereguiluz merged commit 8976844 into symfony:4.4 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @wouterj @OskarStark @HeahDude @carsonbot