Document RenderView method #13264
Merged
Document RenderView method #13264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Feb 27, 2020
| @@ -446,6 +446,19 @@ the :class:`Twig\\Environment` class:: | |||
| } | |||
| } | |||
|
|
|||
| Rendering a Template's Content | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| The ``renderView()`` method renders a template and returns its content. The content from the template can be used to create a ``Response`` object:: | |||
There was a problem hiding this comment.
new line i think here
and also, new line after the its content.
94noni
reviewed
Feb 27, 2020
| 'promotions' => ['...', '...'], | ||
| ); | ||
|
|
||
| return new Response($content); |
There was a problem hiding this comment.
nice idea 👍
i would for example call a specific $response->aMethod() so that readers understand the idea behind getting the view like that and play with the $response before returning it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Current docs doesn't mention renderView() method (Symfony 4.+).