Skip to content

[4.4+] Updated links to Bootstrap docs #13253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

[4.4+] Updated links to Bootstrap docs #13253

merged 1 commit into from
Mar 3, 2020

Conversation

skmedix
Copy link
Contributor

@skmedix skmedix commented Feb 26, 2020 •
edited
Loading

Like in the title. I didn't target this PR to 3.4 as docs there are very different and links to custom components are missing. I can do a separate PR for 3.4 if needed. (My guess is yes as 3.4 is still supported)

@skmedix skmedix changed the base branch from master to 4.4 February 26, 2020 00:22
OskarStark
OskarStark approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

If it’s not too much work a separate PR against 3.4 would be appreciated

@skmedix skmedix changed the title 👽 Updated links to Bootstrap docs [4.4+] Updated links to Bootstrap docs Feb 26, 2020
@skmedix skmedix mentioned this pull request Feb 26, 2020
Merged
OskarStark added a commit that referenced this pull request Mar 3, 2020
@OskarStark
minor #13259 [3.4] Updated links to Bootstrap docs (skmedix)
e929b53 
This PR was merged into the 3.4 branch.

Discussion
----------

[3.4] Updated links to Bootstrap docs

This is a follow up of #13253 for 3.4

Commits
-------

2f99a03 👽 Updated links to Bootstrap docs
@OskarStark OskarStark added this to the 4.4 milestone Mar 3, 2020
@OskarStark
Copy link
Contributor

Thank you @skmedix.

@OskarStark OskarStark merged commit c951204 into symfony:4.4 Mar 3, 2020
@skmedix skmedix deleted the bootstrap-update branch March 3, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@skmedix @OskarStark @carsonbot