Skip to content

Fixed all permanently redirected and broken URLs #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Feb 24, 2020

I ran the linkcheck builder of the 4.4 docs and fixed all broken or permanently redirected links. Most of them are about moving to HTTPS.

We can't run the linkcheck builder automatically:

  • Some docs use permanent redirects to redirect current to a specific version (seems really bad). We want to keep using "current" here
  • In a similair way, some sites allow i18n if you omit the locale from the URL, these are also permanently redirected
  • I don't want us to spam all the links every time GitHub actions runs :)

Also note that Doctrine switched the "latest" version to Doctrine ORM 3.0. I've changed all these to "current" (i.e. 2.6 atm) instead.

@wouterj wouterj requested a review from xabbuh as a code owner February 24, 2020 17:49
@wouterj wouterj force-pushed the linkcheck/4.4-branch branch 4 times, most recently from 904b403 to 3486cf3 Compare February 24, 2020 20:32
@OskarStark
Copy link
Contributor

Can you please fix the build?

Warning, treated as error:
/home/runner/work/symfony-docs/symfony-docs/reference/twig_reference.rst:386: WARNING: undefined label: yaml_encode (if the link has no caption the label must precede a section header)

@wouterj wouterj force-pushed the linkcheck/4.4-branch branch from 3486cf3 to 7f8c72a Compare February 25, 2020 11:21
@wouterj
Copy link
Member Author

wouterj commented Feb 25, 2020

Done :)

@wouterj wouterj merged commit 45effbc into symfony:4.4 Feb 28, 2020
@wouterj wouterj deleted the linkcheck/4.4-branch branch February 28, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants