Skip to content

Add XML schema location for container configuration #13210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

Add XML schema location for container configuration #13210

merged 1 commit into from
Feb 22, 2020

Conversation

ocrampete16
Copy link
Contributor

At first I assumed this was omitted to keep the code snippet more concise and easier to comprehend. But then again, the xsi namespace already in place would be redundant.

If the intention was indeed to keep things more simple, I would suggest removing the xsi namespace entirely.

dbrumann
dbrumann approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addition makes sense. In case someone copies it into their project, they will likely get better code completion-assistance in their IDE when schema location is specified.

wouterj
wouterj approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, all XML examples have the schema location. Seems like we forgot it here somehow.
Thanks!

@ocrampete16 @javiereguiluz
Add XML schema location for container configuration
e917a18 
At first I assumed this was omitted to keep the code snippet more concise and easier to comprehend. But then again, the `xsi` namespace already in place would be redundant.

If the intention was indeed to keep things more simple, I would suggest removing the `xsi` namespace entirely.
@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 February 22, 2020 11:02
@javiereguiluz
Copy link
Member

Good catch, thanks Marco.

@javiereguiluz javiereguiluz merged commit bf2e579 into symfony:4.4 Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ocrampete16 @javiereguiluz @wouterj @dbrumann @carsonbot