Skip to content

[Validator] Allow to define a reusable set of constraints #13195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

[Validator] Allow to define a reusable set of constraints #13195

merged 1 commit into from
Feb 22, 2020

Conversation

ogizanagi
Copy link
Contributor

closes #13075

@ogizanagi ogizanagi requested a review from xabbuh as a code owner February 20, 2020 16:07
@ogizanagi ogizanagi force-pushed the validator-reusable-set-constraints branch 4 times, most recently from dcb5bd9 to 4e2b98e Compare February 20, 2020 16:24
@HeahDude HeahDude added this to the 5.1 milestone Feb 20, 2020
HeahDude
HeahDude reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that cool feature :). Some minor comments about the naming and CS

OskarStark
OskarStark reviewed Feb 21, 2020
View reviewed changes
@ogizanagi ogizanagi force-pushed the validator-reusable-set-constraints branch 2 times, most recently from 638266f to ee8f431 Compare February 21, 2020 09:03
@ogizanagi
Copy link
Contributor Author

Thank you @OskarStark & @HeahDude for your reviews. I've applied your suggestions.

OskarStark
OskarStark reviewed Feb 21, 2020
View reviewed changes
OskarStark
OskarStark reviewed Feb 21, 2020
View reviewed changes
OskarStark
OskarStark reviewed Feb 21, 2020
View reviewed changes
OskarStark
OskarStark reviewed Feb 21, 2020
View reviewed changes
@ogizanagi ogizanagi force-pushed the validator-reusable-set-constraints branch from ee8f431 to 65989d9 Compare February 21, 2020 10:12
@OskarStark OskarStark requested a review from HeahDude February 21, 2020 10:45
@HeahDude
Copy link
Contributor

Thank you Maxime.

@HeahDude HeahDude merged commit de49f6d into symfony:master Feb 22, 2020
@ogizanagi ogizanagi deleted the validator-reusable-set-constraints branch February 22, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Validator] Allow to define a reusable set of constraints
4 participants
@ogizanagi @HeahDude @OskarStark @carsonbot