Skip to content

[Security] clarified the encoding with memory providers #13188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

HeahDude
Copy link
Contributor

Attempt to fix symfony/symfony#35621.

@HeahDude HeahDude force-pushed the security/in_memory-no_salt branch from 503096e to aba29b2 Compare February 19, 2020 20:41
@OskarStark
Copy link
Contributor

Thank you Jules.

@OskarStark OskarStark merged commit bc2970f into symfony:3.4 Feb 20, 2020
This was referenced Feb 20, 2020
@HeahDude HeahDude deleted the security/in_memory-no_salt branch February 20, 2020 17:01
HeahDude added a commit to HeahDude/symfony-docs that referenced this pull request Feb 20, 2020
HeahDude added a commit that referenced this pull request Feb 20, 2020
This PR was merged into the 3.4 branch.

Discussion
----------

Fixed wording of "#13188"

Commits
-------

6db8f75 Fixed wording of "#13188"
HeahDude added a commit to HeahDude/symfony-docs that referenced this pull request Feb 20, 2020
* 3.4:
  Fixed wording of "symfony#13188"
HeahDude added a commit to HeahDude/symfony-docs that referenced this pull request Feb 20, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

Move caution plus reword

Follows symfony#13188

@HeahDude, while up merging symfony#13188, I noticed, that the documents are quite different and the usage of the `memory` provider isn't located in the `security.rst` file anymore.

For now I removed it completely while merging in `4.4` and upper.

This PR is an attempt to move it to the right place. I also take the context (using `auto` algo) into account.

What do you think?

Commits
-------

bba6ba2 Move caution plus reword
HeahDude added a commit to HeahDude/symfony-docs that referenced this pull request Feb 20, 2020
* 4.4:
  minor tweaks
  Fixed wording of "symfony#13188"
  Move caution plus reword
HeahDude added a commit to HeahDude/symfony-docs that referenced this pull request Feb 20, 2020
* 5.0:
  minor tweaks
  Fixed wording of "symfony#13188"
  Move caution plus reword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants