Fix wording #13186
Merged
Fix wording #13186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 19, 2020
HeahDude
reviewed
Feb 19, 2020
| @@ -525,7 +525,7 @@ Troubleshooting | |||
| The ``@group time-sensitive`` and ``@group dns-sensitive`` annotations work | |||
| "by convention" and assume that the namespace of the tested class can be | |||
| obtained just by removing the ``Tests\`` part from the test namespace. I.e. | |||
| that if the your test case fully-qualified class name (FQCN) is | |||
| if your test case's fully-qualified class name (FQCN) is | |||
There was a problem hiding this comment.
Please remove the 's, it's only used for real person, not thing.
|
Thank you, I addressed @HeahDude's comment while merging 👍 |
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Feb 20, 2020
* 3.4: minor. refs symfony#13186 [Security] clarified the encoding with memory providers Fix wording
OskarStark
added a commit
that referenced
this pull request
Feb 20, 2020
* 4.4: minor. refs #13186 [Security] clarified the encoding with memory providers Fix wording
OskarStark
added a commit
that referenced
this pull request
Feb 20, 2020
* 5.0: minor. refs #13186 [Security] clarified the encoding with memory providers Fix wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.