[Tests] added a note about installing PHPUnit dependencies #13184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Feb 22, 2020
testing.rst
Outdated
| @@ -31,6 +31,17 @@ command: | |||
|
|
|||
| $ ./vendor/bin/simple-phpunit | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
What if we rework the part above (where we already list the command) to say something like: “after the library downloads, try executing phpstorm by running: (then the terminal block). The first time you run this, it will download PHPUnit itself and make its classes available in your app.
There was a problem hiding this comment.
Thanks, I reworded as you suggest.
HeahDude
force-pushed
the
note-phpunit-bridge-install
branch
from
fa6d8ae to
2c10047
Compare
|
Thank you Jules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first installing the bridge, one cannot start working by extending the
TestCasesince the bridge has no requirements.It is not obvious that they are installed the first time we run the test suite, neither that we should run it without tests to get started.
Let's make all that explicit with a short note.