Fix customize notification example #13177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
commented
Feb 18, 2020
| } | ||
|
|
||
| return 'email'; | ||
| return ['email']; |
There was a problem hiding this comment.
The Notification::getChannels(...) methods needs to return an array.
jschaedl
commented
Feb 18, 2020
| @@ -500,10 +500,10 @@ very high and the recipient has a phonenumber:: | |||
| && $recipient instanceof AdminRecipient | |||
| && null !== $recipient->getPhone() | |||
| ) { | |||
| return ['sms', 'email']; | |||
| return ['sms']; | |||
There was a problem hiding this comment.
This example is about returning the sms channel only in case the price is high and the recipient has a phone number.
|
Can you change this line too: |
|
@OskarStark fixed |
OskarStark
approved these changes
Feb 18, 2020
|
Thank you Jan. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 18, 2020
This PR was merged into the 5.0 branch. Discussion ---------- Fix customize notification example Commits ------- f6d8eae Fix customize notification example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.