fixing typo #13158
Merged
fixing typo #13158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was squashed before being merged into the 3.4 branch (closes #13131). Discussion ---------- Replace deprecated ObjectManager ```Doctrine\Common\Persistence\ObjectManager``` is deprecated and should be replaced with ```Doctrine\Persistence\ManagerRegistry``` this is supported in symfony/doctrine-bridge now symfony/doctrine-bridge@c94d84f Commits ------- a10dab6 Replace deprecated ObjectManager
This PR was merged into the 3.4 branch. Discussion ---------- [Security] fixed XML config <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0a244fd [Security] Various minor fixes in XML config
…er for all user types (HeahDude) This PR was merged into the 3.4 branch. Discussion ---------- [Security] renamed memory provider and a tip about encoder for all user types A follow up of symfony/recipes#741. Commits ------- bdccc33 [Security] renamed memory provider
|
Karim, this was a super nice catch! Thanks for fixing it. We merged it in 3.4 branch (and also, in all the other supported branches). |
javiereguiluz
added a commit
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.