Added reasoning to autowiring in public bundles #13063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 6, 2020
wouterj
approved these changes
Feb 6, 2020
javiereguiluz
force-pushed
the
patch-3
branch
from
abb69f9 to
35d2e97
Compare
|
Thank you Yanick. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 7, 2020
This PR was squashed before being merged into the 3.4 branch (closes #13063). Discussion ---------- Added reasoning to autowiring in public bundles Right now it's just a statement without any arguments which might confuse readers. Commits ------- 35d2e97 Added reasoning to autowiring in public bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's just a statement without any arguments which might confuse readers.