Fix versions in Upgrading Major Version #13029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Feb 4, 2020
|
@HeahDude Done! I can target 4.4, but then you'd have to merge it to master as well, am I mistaken? |
|
We merge this afterwards to master |
OskarStark
approved these changes
Feb 4, 2020
|
So should I retarget to |
|
You can if you want, but we use an internal tool to merge PRs and can do it otherwise, thanks. |
|
Thank you Benjamin. |
OskarStark
added a commit
that referenced
this pull request
Feb 5, 2020
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes #13029). Discussion ---------- Fix versions in Upgrading Major Version This PR fixes the versions of the upgrade: `4.4 -> 5.0` instead of `4.3 -> 4.4`. I'm also suggesting a change to the following wording: > (...) follow their own versioning scheme. to make the sentence clearer. Commits ------- 19e1ec7 Fix versions in Upgrading Major Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the versions of the upgrade:
4.4 -> 5.0instead of4.3 -> 4.4.I'm also suggesting a change to the following wording:
to make the sentence clearer.