Fix example with iterable #13027
Merged
Fix example with iterable #13027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
approved these changes
Feb 4, 2020
| @@ -105,11 +105,17 @@ which starts, advances and finishes the progress bar automatically:: | |||
|
|
|||
| $progressBar = new ProgressBar($output); | |||
|
|
|||
| // $iterable can be for example an array ([1, 2, 3, ...]) or a generator | |||
| // $iterable = function () { yield 1; yield 2; ... }; | |||
| // $iterable can be for example an array ([1, 2, 3, ...]) | |||
There was a problem hiding this comment.
Maybe it could be reworded now to something like // $iterable can be an array
OskarStark
added a commit
that referenced
this pull request
Feb 5, 2020
This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.4 branch instead (closes #13027). Discussion ---------- Fix example with iterable The old example throws this error; `PHP Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Console\Helper\ProgressBar::iterate() must be iterable, object given` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 36b6e43 Fix example with iterable
OskarStark
added a commit
that referenced
this pull request
Feb 5, 2020
* 4.4: minor. refs #13027 Fix example with iterable
OskarStark
added a commit
that referenced
this pull request
Feb 5, 2020
* 5.0: minor. refs #13027 Fix example with iterable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old example throws this error;
PHP Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Console\Helper\ProgressBar::iterate() must be iterable, object given