Update service_container.rst #12985
Merged
Update service_container.rst #12985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-vo
force-pushed
the
patch-4
branch
3 times, most recently
from
1cb10a0 to
aa595f4
Compare
HeahDude
suggested changes
Feb 4, 2020
l-vo
force-pushed
the
patch-4
branch
2 times, most recently
from
1081fc0 to
a63e7bd
Compare
|
@HeahDude ContainerConfiguration used instead of register calls 🙂 |
l-vo
force-pushed
the
patch-4
branch
2 times, most recently
from
e85f57d to
380f946
Compare
HeahDude
suggested changes
Feb 12, 2020
|
@HeahDude Requested changes done :) |
HeahDude
approved these changes
Feb 13, 2020
OskarStark
approved these changes
Feb 15, 2020
javiereguiluz
force-pushed
the
patch-4
branch
from
97b1d0b to
b274029
Compare
|
These are very nice changes! Thanks Laurent. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 15, 2020
This PR was squashed before being merged into the 4.4 branch (closes #12985). Discussion ---------- Update service_container.rst From Symfony 4.0, there is no `public: false` in `_defaults` anymore. As I understand it's the default value (`true`) of the property `private` in [Definition class](https://github.com/symfony/symfony/blob/4.0/src/Symfony/Component/DependencyInjection/Definition.php) + the [ResolvePrivatesPass]( https://github.com/symfony/symfony/blob/4.0/src/Symfony/Component/DependencyInjection/Compiler/ResolvePrivatesPass.php) compiler pass that make services as private by default. Commits ------- b274029 Update service_container.rst
OskarStark
added a commit
that referenced
this pull request
Feb 19, 2020
…hDude) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fixed public service use case Supersedes #12977 which was merged in 5.0, this time using a different approach and targeting 4.4. Fixes #12978 and complements #12985. Commits ------- 3694980 [DependencyInjection] Fixed public service use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Symfony 4.0, there is no
public: falsein_defaultsanymore. As I understand it's the default value (true) of the propertyprivatein Definition class + the ResolvePrivatesPass compiler pass that make services as private by default.