tweaking the password upgrading functionality #12960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Jan 19, 2020
wouterj
approved these changes
Jan 19, 2020
|
|
||
| * New users will be encoded with the new algorithm; | ||
| * Whenever a user logs in whose password is still stored using the old algorithm, | ||
| Symfony will verify the password with the old algorithm and then re-encode |
There was a problem hiding this comment.
Suggested change
| Symfony will verify the password with the old algorithm and then re-encode | |
| Symfony will verify the password with the old algorithm and then rehash |
Confusing Symfony terminology, but the password encoders are doing hashing. This is also consistent with earlier uses of "rehash(ing)" in the beginning of this chapter.
There was a problem hiding this comment.
I made this change while merging.
javiereguiluz
approved these changes
Jan 20, 2020
OskarStark
approved these changes
Jan 21, 2020
javiereguiluz
force-pushed
the
password-migrating
branch
from
dbdc010 to
94fc0b4
Compare
|
Thanks Ryan. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 21, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #12960). Discussion ---------- tweaking the password upgrading functionality Hi! Minor tweaks to the password upgrading section as I read through it - it was already quite good. Commits ------- 94fc0b4 tweaking the password upgrading functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Minor tweaks to the password upgrading section as I read through it - it was already quite good.