Remove usages of transChoice() method for Symfony 5.0 #12957
Merged
+6
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Jan 19, 2020
components/translation/usage.rst
Outdated
| Pluralized Translations | ||
| ----------------------- | ||
|
|
||
| Translation messages can be pluralized using `interval notations`_, the count |
There was a problem hiding this comment.
where the counter value to choose the right translation can be provided using
Wdyt?
There was a problem hiding this comment.
Thanks for the feedback, I've removed this section based on this comment: #12957 (review)
|
@wouterj would you be able to review this PR? Thanks 🙏 |
wouterj
requested changes
Jan 19, 2020
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
|
Thanks for the comments, based on the feedback I've removed the |
wouterj
approved these changes
Jan 19, 2020
xabbuh
approved these changes
Jan 20, 2020
|
@xabbuh should I change the target branch? |
|
@kane-menicou Thank you, but we use a tool for merging that is able to do it. So it's not really necessary for you to change it. :) |
javiereguiluz
approved these changes
Jan 20, 2020
javiereguiluz
force-pushed
the
remove-usages-of-trans-choice
branch
from
ba613ad to
73376df
Compare
|
Thank you Kane. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 21, 2020
…ane-menicou) This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.4 branch instead (closes #12957). Discussion ---------- Remove usages of transChoice() method for Symfony 5.0 The `transChoice()` method and the `transChoice` Twig filter [were removed in Symfony 5.0](https://github.com/symfony/symfony/blob/master/UPGRADE-5.0.md#frameworkbundle) **Notes for reviewers:** I'm not too sure about the new `Pluralized Translations` section, I couldn't find any other information about it in the docs so maybe it's relevant? I'm not sure if there's a better place to put it (maybe: `components/translation.rst`), or if it's even needed? Commits ------- 73376df Remove usages of transChoice() method for Symfony 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transChoice()method and thetransChoiceTwig filter were removed in Symfony 5.0Notes for reviewers: I'm not too sure about the new
Pluralized Translationssection, I couldn't find any other information about it in the docs so maybe it's relevant? I'm not sure if there's a better place to put it (maybe:components/translation.rst), or if it's even needed?