Skip to content

Fixes unclear sentence in finder.rst #12912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

kane-menicou
Copy link
Contributor

No description provided.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thank you

@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 12, 2020

I agree that the original phrase can be improved ... but I'm not sure about the new proposal because it still doesn't explain the methods explicitly (it says "granular results" instead of "files only or dirs only").

What about something like this instead:

By default, the Finder returns both files and directories. If you need to find
either files or directories only, use the :method:`Symfony\\Component\\Finder\\Finder::files`
and :method:`Symfony\\Component\\Finder\\Finder::directories` methods::

@javiereguiluz
Copy link
Member

@kane-menicou thanks for improving Symfony Docs and thanks for being so open to our comments!

javiereguiluz added a commit that referenced this pull request Jan 13, 2020
This PR was squashed before being merged into the 3.4 branch (closes #12912).

Discussion
----------

Fixes unclear sentence in finder.rst

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

6011b51 Fixes unclear sentence in finder.rst
@javiereguiluz javiereguiluz merged commit 6011b51 into symfony:3.4 Jan 13, 2020
@kane-menicou kane-menicou deleted the kane-menicou-patch-3 branch January 13, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants