[Testing] Fix broken link #12881
Merged
[Testing] Fix broken link #12881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right ... but instead of AbstractBrowser, which is an abstract class that cannot be instantiated ... we should use HttpBrowser, right? |
|
Yes, HttpBrowser should be used, but I think that since the goal here is to show the xmlHttpRequest method, it makes sense to point to the file that implements it, do you agree ? Or, as there are some other methods from the same page that do not point to their implementation, perhaps this link can be removed if it is not necessary. |
|
Using |
|
Merged! Sorry it took us so long. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a broken link here : https://symfony.com/doc/current/testing.html#ajax-requests
Symfony/Component/BrowserKit/Client has been replaced by Symfony/Component/BrowserKit/AbstractBrowser in 5.0