-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[4.4][Security] Password migration with guards #12853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xabbuh
merged 1 commit into
symfony:4.4
from
wouterj:issue-12756/password-migration-guards
Jan 1, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,14 +119,41 @@ Upgrade the Password | |
|
||
Upon successful login, the Security system checks whether a better algorithm | ||
is available to hash the user's password. If it is, it'll hash the correct | ||
password using the new hash. You can enable this behavior by implementing how | ||
this newly hashed password should be stored: | ||
password using the new hash. If you use a Guard authenticator, you first need to | ||
`provide the original password to the Security system <Provide the Password when using Guards>`_. | ||
|
||
You can enable the upgrade behavior by implementing how this newly hashed | ||
password should be stored: | ||
|
||
* `When using Doctrine's entity user provider <Upgrade the Password when using Doctrine>`_ | ||
* `When using a custom user provider <Upgrade the Password when using a custom User Provider>`_ | ||
|
||
After this, you're done and passwords are always hashed as secure as possible! | ||
|
||
Provide the Password when using Guard | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
When you're using a custom :doc:`guard authenticator </security/guard_authentication>`, | ||
you need to implement :class:`Symfony\\Component\\Security\\Guard\\PasswordAuthenticatedInterface`. | ||
This interface defines a ``getPassword()`` method that returns the password | ||
for this login request. This password is used in the migration process:: | ||
|
||
// src/Security/CustomAuthenticator.php | ||
namespace App\Security; | ||
|
||
use Symfony\Component\Security\Guard\PasswordAuthenticatedInterface; | ||
// ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing the use of AbstractGuardAuthenticator no? |
||
|
||
class CustomAuthenticator extends AbstractGuardAuthenticator implements PasswordAuthenticatedInterface | ||
{ | ||
// ... | ||
|
||
public function getPassword($credentials): ?string | ||
{ | ||
return $credentials['password']; | ||
xabbuh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
Upgrade the Password when using Doctrine | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.